Expand filename (#7893)

* Fix double env
* Properly expand name in attach step
* Update maintaining docs
This commit is contained in:
Evert Timberg 2020-10-16 07:40:49 -04:00 committed by GitHub
parent 64b4529486
commit 0c61d55682
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 19 deletions

View File

@ -68,6 +68,6 @@ jobs:
VERSION: ${{ github.event.release.tag_name }} VERSION: ${{ github.event.release.tag_name }}
with: with:
upload_url: ${{ github.event.release.upload_url }} upload_url: ${{ github.event.release.upload_url }}
asset_path: chart.js-$VERSION.tgz asset_path: ${{ format('chart.js-{0}.tgz', github.event.release.tag_name) }}
asset_name: chart.js-$VERSION.tgz asset_name: ${{ format('chart.js-{0}.tgz', github.event.release.tag_name) }}
asset_content_type: application/gzip asset_content_type: application/gzip

View File

@ -4,32 +4,20 @@ Chart.js relies on [Travis CI](https://travis-ci.org/) to automate the library [
### Releasing a New Version ### Releasing a New Version
1. draft release notes on [GitHub](https://github.com/chartjs/Chart.js/releases/new) for the upcoming tag 1. Update the release version on [GitHub](https://github.com/chartjs/Chart.js/releases/new) for the release drafted by the `release-drafter` tool
1. update `master` `package.json` version using [semver](https://semver.org/) semantic 2. Publish the release
1. merge `master` into the `release` branch 3. follow the build process on [GitHub Actions](https://github.com/chartjs/Chart.js/actions?query=workflow%3A%22Node.js+Package%22)
1. follow the build process on [Travis CI](https://travis-ci.org/chartjs/Chart.js)
> **Note:** if `master` is merged in `release` with a `package.json` version that already exists, the tag
creation fails and the release process is aborted.
### Automated Tasks
Merging into the `release` branch kicks off the automated release process:
* build of the `dist/*.js` files
* `dist/*.js` is added to a detached branch
* a tag is created from the `package.json` version
* tag (with dist files) is pushed to GitHub
Creation of this tag triggers a new build: Creation of this tag triggers a new build:
* `Chart.js.zip` package is generated, containing dist files and examples * `Chart.js.zip` package is generated, containing dist files and examples
* `dist/*.js` and `Chart.js.zip` are attached to the GitHub release (downloads) * `dist/*.js` and `Chart.js.zip` are attached to the GitHub release (downloads)
* a new npm package is published on [npmjs](https://www.npmjs.com/package/chart.js) * A new npm package is published on [npmjs](https://www.npmjs.com/package/chart.js)
Finally, [cdnjs](https://cdnjs.com/libraries/Chart.js) is automatically updated from the npm release. Finally, [cdnjs](https://cdnjs.com/libraries/Chart.js) is automatically updated from the npm release.
### Further Reading ### Further Reading
* [Travis GitHub releases](https://github.com/chartjs/Chart.js/pull/2555) * [GitHub Action releases](https://github.com/chartjs/Chart.js/pull/7891)
* [dist/* files](https://github.com/chartjs/Chart.js/issues/3033) * [dist/* files](https://github.com/chartjs/Chart.js/issues/3033)
* [cdnjs npm auto update](https://github.com/cdnjs/cdnjs/pull/8401) * [cdnjs npm auto update](https://github.com/cdnjs/cdnjs/pull/8401)