Remove futile optimization (#6928)

This commit is contained in:
Jukka Kurkela 2020-01-07 18:27:44 +02:00 committed by Evert Timberg
parent 59120c38f4
commit 2dd0c2f8fe
2 changed files with 4 additions and 8 deletions

View File

@ -125,9 +125,8 @@ module.exports = DatasetController.extend({
const firstOpts = me._resolveDataElementOptions(start, mode);
const sharedOptions = me._getSharedOptions(mode, points[start], firstOpts);
const includeOptions = me._includeOptions(mode, sharedOptions);
let i;
for (i = 0; i < points.length; i++) {
for (let i = 0; i < points.length; i++) {
const point = points[i];
const index = start + i;
const parsed = !reset && me._getParsed(index);
@ -140,8 +139,7 @@ module.exports = DatasetController.extend({
};
if (includeOptions) {
properties.options = i === 0 ? firstOpts
: me._resolveDataElementOptions(i, mode);
properties.options = me._resolveDataElementOptions(i, mode);
if (reset) {
properties.options.radius = 0;

View File

@ -98,9 +98,8 @@ module.exports = DatasetController.extend({
const firstOpts = me._resolveDataElementOptions(start, mode);
const sharedOptions = me._getSharedOptions(mode, points[start], firstOpts);
const includeOptions = me._includeOptions(mode, sharedOptions);
let i;
for (i = 0; i < points.length; ++i) {
for (let i = 0; i < points.length; ++i) {
const index = start + i;
const point = points[i];
const parsed = me._getParsed(index);
@ -113,8 +112,7 @@ module.exports = DatasetController.extend({
};
if (includeOptions) {
properties.options = i === 0 ? firstOpts
: me._resolveDataElementOptions(index, mode);
properties.options = me._resolveDataElementOptions(index, mode);
}
me._updateElement(point, index, properties, mode);