Allow fill: true and null in ChartDataset.data (#8700)

* Handle `fill: true`
* ChartDataset allow number/null data
This commit is contained in:
Evert Timberg 2021-03-22 18:59:50 -04:00 committed by GitHub
parent e51a401449
commit 2fc98ddc39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 4 deletions

View File

@ -1966,7 +1966,7 @@ export interface FillerOptions {
propagate: boolean;
}
export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | false;
export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | boolean;
export interface ComplexFillTarget {
/**
@ -3207,14 +3207,14 @@ export interface ChartTypeRegistry {
line: {
chartOptions: LineControllerChartOptions;
datasetOptions: LineControllerDatasetOptions & FillerControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint;
defaultDataPoint: ScatterDataPoint | number | null;
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
};
scatter: {
chartOptions: ScatterControllerChartOptions;
datasetOptions: ScatterControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint;
defaultDataPoint: ScatterDataPoint | number | null;
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
};
@ -3249,7 +3249,7 @@ export interface ChartTypeRegistry {
radar: {
chartOptions: RadarControllerChartOptions;
datasetOptions: RadarControllerDatasetOptions;
defaultDataPoint: number;
defaultDataPoint: number | null;
parsedDataType: RadialParsedData;
scales: keyof RadialScaleTypeRegistry;
};

View File

@ -0,0 +1,16 @@
import { ChartDataset } from '../index.esm';
const dataset: ChartDataset = {
data: [10, null, 20],
};
const lineDataset: ChartDataset<'line'> = {
data: [10, null, 20],
};
const scatterDataset: ChartDataset<'scatter'> = {
data: [10, null, 20],
};
const radarDataset: ChartDataset<'radar'> = {
data: [10, null, 20],
};

View File

@ -0,0 +1,6 @@
import { ChartDataset } from '../../../index.esm';
const dataset: ChartDataset = {
data: [],
fill: true,
};