From 63b14dde1574e84e7af69bfec046958f984bb226 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Tue, 27 Jan 2015 13:35:30 -0500 Subject: [PATCH] Clean up PR process --- CONTRIBUTING.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5812f0fdc..39ddfca51 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,9 +25,9 @@ Guidlines for reporting bugs: - Check the issue search to see if it has already been reported - Isolate the problem to a simple test case - - Provide a demonstration of the problem on [jsbin](http://jsbin.com) or similar + - Provide a demonstration of the problem on [JS Bin](http://jsbin.com) or similar -Please provide any additional details associated with the bug, if it's browser of screen density specific, or only happens with a certain configuration or data. +Please provide any additional details associated with the bug, if it's browser or screen density specific, or only happens with a certain configuration or data. Pull requests @@ -37,12 +37,13 @@ Clear, concise pull requests are excellent at continuing the project's community Guidlines: - - Please ask before starting significant work on a pull request to check it's a change within the project scope, and isn't a duplicate effort - - Please make changes to the files in [`/src`](https://github.com/nnnick/Chart.js/tree/master/src), not `Chart.js` or `Chart.min.js` in the repo root directory + - Please create an issue first: + - For bugs, we can discuss the fixing approach + - For enhancements, we can discuss if it is within the project scope and avoid duplicate effort + - Please make changes to the files in [`/src`](https://github.com/nnnick/Chart.js/tree/master/src), not `Chart.js` or `Chart.min.js` in the repo root directory, this avoids merge conflicts - Tabs for indentation, not spaces please - If adding new functionality, please also update the relevant `.md` file in [`/docs`](https://github.com/nnnick/Chart.js/tree/master/docs) - Please make your commits in logical sections with clear commit messages - - Please avoid committing in the build Chart.js & Chart.min.js file, as it may cause conflicts when merging back Joining the Project -------------