Mirrors/Chart.js
1
0
Fork 0
mirror of https://github.com/chartjs/Chart.js.git synced 2024-10-06 12:19:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Define with let to avoid "assignment to constant" errors (#9803)

Browse Source 
* Define with let to avoid "assignment to constant" errors

Thanks for this example. Defining `label` with `const` rather than `let` results in `Uncaught TypeError: Assignment to constant variable.`

* Another case where const needs to be replaced with let.

* Requested cases where const needs to be replaced with let +1 (style).
This commit is contained in:
Eric Theise 2021-10-30 06:23:14 -07:00 committed by GitHub
parent 1749e57918
commit 67c5a85144
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/configuration/tooltip.md
View File

@ -5,7 +5,7 @@
Namespace: `options.plugins.tooltip`, the global options for the chart tooltips is defined in `Chart.defaults.plugins.tooltip`. Namespace: `options.plugins.tooltip`, the global options for the chart tooltips is defined in `Chart.defaults.plugins.tooltip`.
:::warning :::warning
The bubble, doughnut, pie, polar area, and scatter charts override the tooltip defaults. To change the overrides for those chart types, the options are defined in `Chart.overrides[type].plugins.tooltip`. The bubble, doughnut, pie, polar area, and scatter charts override the tooltip defaults. To change the overrides for those chart types, the options are defined in `Chart.overrides[type].plugins.tooltip`.
::: :::
| Name | Type | Default | Description | Name | Type | Default | Description
@ -157,7 +157,7 @@ const chart = new Chart(ctx, {
tooltip: { tooltip: {
callbacks: { callbacks: {
label: function(context) { label: function(context) {
const label = context.dataset.label || ''; let label = context.dataset.label || '';
if (label) { if (label) {
label += ': '; label += ': ';
@ -282,7 +282,7 @@ const myPieChart = new Chart(ctx, {
external: function(context) { external: function(context) {
// Tooltip Element // Tooltip Element
const tooltipEl = document.getElementById('chartjs-tooltip'); let tooltipEl = document.getElementById('chartjs-tooltip');
// Create element on first render // Create element on first render
if (!tooltipEl) { if (!tooltipEl) {
@ -316,7 +316,7 @@ const myPieChart = new Chart(ctx, {
const titleLines = tooltipModel.title || []; const titleLines = tooltipModel.title || [];
const bodyLines = tooltipModel.body.map(getBody); const bodyLines = tooltipModel.body.map(getBody);
const innerHtml = '<thead>'; let innerHtml = '<thead>';
titleLines.forEach(function(title) { titleLines.forEach(function(title) {
innerHtml += '<tr><th>' + title + '</th></tr>'; innerHtml += '<tr><th>' + title + '</th></tr>';
@ -325,7 +325,7 @@ const myPieChart = new Chart(ctx, {
bodyLines.forEach(function(body, i) { bodyLines.forEach(function(body, i) {
const colors = tooltipModel.labelColors[i]; const colors = tooltipModel.labelColors[i];
const style = 'background:' + colors.backgroundColor; let style = 'background:' + colors.backgroundColor;
style += '; border-color:' + colors.borderColor; style += '; border-color:' + colors.borderColor;
style += '; border-width: 2px'; style += '; border-width: 2px';
const span = '<span style="' + style + '"></span>'; const span = '<span style="' + style + '"></span>';
@ -333,7 +333,7 @@ const myPieChart = new Chart(ctx, {
}); });
innerHtml += '</tbody>'; innerHtml += '</tbody>';
const tableRoot = tooltipEl.querySelector('table'); let tableRoot = tooltipEl.querySelector('table');
tableRoot.innerHTML = innerHtml; tableRoot.innerHTML = innerHtml;
} }

4
docs/developers/updates.md
View File

@ -66,8 +66,8 @@ Variables referencing any one from `chart.scales` would be lost after updating s
```javascript ```javascript
function updateScales(chart) { function updateScales(chart) {
const xScale = chart.scales.x; let xScale = chart.scales.x;
const yScale = chart.scales.y; let yScale = chart.scales.y;
chart.options.scales = { chart.options.scales = {
newId: { newId: {
display: true display: true