From ae65fde3e9df1ad2ccd239733456d43fc7fec1f0 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Fri, 26 Sep 2014 12:37:51 -0400 Subject: [PATCH 1/4] [CONTROVERSIAL] Update scope: new chart types are off topic --- CONTRIBUTING.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b362dcf4..7226e7470 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,16 @@ New contributions to the library are welcome, just a couple of guidelines: * Tabs for indentation, not spaces please. * Please ensure you're changing the individual files in /src, not the concatenated output in the Chart.js file in the root of the repo. - * Please check that your code will pass jshint code standards, gulp jshint will run this for you. + * Please check that your code will pass jshint code standards, `gulp jshint` will run this for you. * Please keep pull requests concise, and document new functionality in the relevant .md file. * Consider whether your changes are useful for all users, or if creating a Chart.js extension would be more appropriate. * Please avoid committing in the build Chart.js & Chart.min.js file, as it causes conflicts when merging. + +New Chart Types +=============== + +Chart.js is designed to be modular. See http://www.chartjs.org/docs/#advanced-usage-writing-new-chart-types + +All discussion of new chart types (horizontal bar charts, X-Y scatter plot, etc.) should be done in the Chart.js Google Group at https://groups.google.com/forum/#!forum/chartjs-user-discussion This will get the most exposure for getting people to help define requirements, complete programming and documentation of your vision. + +Please do not request new chart types in the project issues. Fully implemented, documented, and useful new charts may be added to the project via a Pull Request. From 7eabb701300bf64d285ac9a94b2d9769d8ab9767 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Wed, 1 Oct 2014 12:18:47 -0400 Subject: [PATCH 2/4] Add strict language to README. --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f34ae1938..3675a5f74 100644 --- a/README.md +++ b/README.md @@ -13,3 +13,5 @@ Chart.js is available under the [MIT license](http://opensource.org/licenses/MIT ## Bugs & issues When reporting bugs or issues, if you could include a link to a simple [jsbin](http://jsbin.com) or similar demonstrating the issue, that'd be really helpful. + +This project is modular and supports separately-maintained new chart types. This project's scope includes only the chart types included. New chart types will be considered for inclusion in the project if they incude passing build tests and have complete documentation. Please discuss new or "missing" chart types in the [Chart.js User Discussion](https://groups.google.com/forum/#!forum/chartjs-user-discussion) Google Group and not in Issues. For more information, please also see the CONTRIBUTING file. From 8522d4e60e163c55198ad80d39a9db346a7e61b5 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Mon, 29 Dec 2014 15:38:03 -0500 Subject: [PATCH 3/4] Update to have new chart types in external repos --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7226e7470..c617dc7ab 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,4 +17,4 @@ Chart.js is designed to be modular. See http://www.chartjs.org/docs/#advanced-us All discussion of new chart types (horizontal bar charts, X-Y scatter plot, etc.) should be done in the Chart.js Google Group at https://groups.google.com/forum/#!forum/chartjs-user-discussion This will get the most exposure for getting people to help define requirements, complete programming and documentation of your vision. -Please do not request new chart types in the project issues. Fully implemented, documented, and useful new charts may be added to the project via a Pull Request. +Please do not request new chart types in the project issues. Fully implemented, documented, and useful new charts may be maintained in a new repository. Later, we may add a link to selected external repositories from this project. From f81d6f45e19da797def2709551ef2fde2d1c1a1d Mon Sep 17 00:00:00 2001 From: William Entriken Date: Mon, 29 Dec 2014 15:40:09 -0500 Subject: [PATCH 4/4] Update readme about where to put new chart types --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3675a5f74..19357c1c0 100644 --- a/README.md +++ b/README.md @@ -14,4 +14,4 @@ Chart.js is available under the [MIT license](http://opensource.org/licenses/MIT When reporting bugs or issues, if you could include a link to a simple [jsbin](http://jsbin.com) or similar demonstrating the issue, that'd be really helpful. -This project is modular and supports separately-maintained new chart types. This project's scope includes only the chart types included. New chart types will be considered for inclusion in the project if they incude passing build tests and have complete documentation. Please discuss new or "missing" chart types in the [Chart.js User Discussion](https://groups.google.com/forum/#!forum/chartjs-user-discussion) Google Group and not in Issues. For more information, please also see the CONTRIBUTING file. +This project is modular and supports separately-maintained new chart types. This project's scope includes only the chart types included. New chart types should be created and maintained in separate repositories. We may consider linking to them from this project if they incude passing build tests and have complete documentation. Please discuss new or "missing" chart types in the [Chart.js User Discussion](https://groups.google.com/forum/#!forum/chartjs-user-discussion) Google Group and not in Issues. For more information, please also see the CONTRIBUTING file.