Check colors definition in the chart options (#11003)

* Check colors definition in the chart options

* Update src/plugins/plugin.colors.ts

Co-authored-by: Dan Onoshko <danon0404@gmail.com>

* Update src/plugins/plugin.colors.ts

Co-authored-by: Dan Onoshko <danon0404@gmail.com>

* Update src/plugins/plugin.colors.ts

Co-authored-by: Dan Onoshko <danon0404@gmail.com>

* apply review

Co-authored-by: Dan Onoshko <danon0404@gmail.com>
This commit is contained in:
stockiNail 2023-01-18 13:31:33 +01:00 committed by GitHub
parent 97bc329d72
commit ab55f6c976
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 47 additions and 3 deletions

View File

@ -81,6 +81,12 @@ function containsColorsDefinitions(
return false;
}
function containsColorsDefinition(
descriptor: ColorsDescriptor
) {
return descriptor && (descriptor.borderColor || descriptor.backgroundColor);
}
export default {
id: 'colors',
@ -95,11 +101,12 @@ export default {
}
const {
options: {elements},
data: {datasets}
data: {datasets},
options: chartOptions
} = chart.config;
const {elements} = chartOptions;
if (!options.forceOverride && (containsColorsDefinitions(datasets) || elements && containsColorsDefinitions(elements))) {
if (!options.forceOverride && (containsColorsDefinitions(datasets) || containsColorsDefinition(chartOptions) || (elements && containsColorsDefinitions(elements)))) {
return;
}

View File

@ -0,0 +1,37 @@
module.exports = {
config: {
type: 'bar',
data: {
labels: [0, 1, 2, 3, 4, 5],
datasets: [
{
data: [0, 5, 10, null, -10, -5],
},
{
data: [10, 2, 3, null, 10, 5]
}
]
},
options: {
backgroundColor: ['red', 'green'],
scales: {
x: {
ticks: {
display: false,
}
},
y: {
ticks: {
display: false,
}
}
},
plugins: {
legend: false,
colors: {
enabled: true
}
}
}
}
};

Binary file not shown.

After

Width:  |  Height:  |  Size: 15 KiB