From ae65fde3e9df1ad2ccd239733456d43fc7fec1f0 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Fri, 26 Sep 2014 12:37:51 -0400 Subject: [PATCH] [CONTROVERSIAL] Update scope: new chart types are off topic --- CONTRIBUTING.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b362dcf4..7226e7470 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,16 @@ New contributions to the library are welcome, just a couple of guidelines: * Tabs for indentation, not spaces please. * Please ensure you're changing the individual files in /src, not the concatenated output in the Chart.js file in the root of the repo. - * Please check that your code will pass jshint code standards, gulp jshint will run this for you. + * Please check that your code will pass jshint code standards, `gulp jshint` will run this for you. * Please keep pull requests concise, and document new functionality in the relevant .md file. * Consider whether your changes are useful for all users, or if creating a Chart.js extension would be more appropriate. * Please avoid committing in the build Chart.js & Chart.min.js file, as it causes conflicts when merging. + +New Chart Types +=============== + +Chart.js is designed to be modular. See http://www.chartjs.org/docs/#advanced-usage-writing-new-chart-types + +All discussion of new chart types (horizontal bar charts, X-Y scatter plot, etc.) should be done in the Chart.js Google Group at https://groups.google.com/forum/#!forum/chartjs-user-discussion This will get the most exposure for getting people to help define requirements, complete programming and documentation of your vision. + +Please do not request new chart types in the project issues. Fully implemented, documented, and useful new charts may be added to the project via a Pull Request.