Chart.js

Mirrors/Chart.js

Fork 0

mirror of https://github.com/chartjs/Chart.js.git synced 2024-10-06 12:19:08 +02:00

Commit Graph

Author	SHA1	Message	Date
Simon Brunel	c6bda02468	Rewrite unit test waitForResize helper (#4566 ) The original implementation tries to intercept events from the chart internal iframe, which ones failing on Chrome 60. Checking internals doesn't seem the best approach, instead we could consider that a chart has been resized after the resize method has been called and processed. So let's hook `Chart.resize` and callback once it's done.	2017-07-26 13:33:45 +02:00
Simon Brunel	ecca3373b2	Increase ESLint complexity and add config for tests (#4421 ) Raise the cyclomatic complexity to 10 which seems to better match the project coding style and still reasonable (6 being quite low). Also move unit tests specific eslint rules in the cascaded `./test/.eslintrc` file (previously in `gulp.js`).	2017-07-01 09:55:11 +02:00

Author

SHA1

Message

Date

Simon Brunel

c6bda02468

Rewrite unit test waitForResize helper (#4566 )

The original implementation tries to intercept events from the chart internal iframe, which ones failing on Chrome 60. Checking internals doesn't seem the best approach, instead we could consider that a chart has been resized after the resize method has been called and processed. So let's hook `Chart.resize` and callback once it's done.

2017-07-26 13:33:45 +02:00

Simon Brunel

ecca3373b2

Increase ESLint complexity and add config for tests (#4421 )

Raise the cyclomatic complexity to 10 which seems to better match the project coding style and still reasonable (6 being quite low). Also move unit tests specific eslint rules in the cascaded `./test/.eslintrc` file (previously in `gulp.js`).

2017-07-01 09:55:11 +02:00

2 Commits