mirror of
https://github.com/chartjs/Chart.js.git
synced 2024-10-06 12:19:08 +02:00
c057c96693
* Refactor get...Items functions to take events rather than positions To work toward exposing something like the get...Items functions. * Switch getAxisItems to use optimizedEvaluateItems optimizedEvaluateItems falls back to evaluating all items for unsorted items, and sorting / optimizing ought to be okay, so this ought to be equivalent. * Performance * Consolidate getRelativePosition helpers.dom.js's getRelativePosition already had logic to handle ChartEvent vs. Event (as demonstrated by the `native` check within `getCanvasPosition`), so it's redundant for core.interaction.js to have its own `native` check. Update `getRelativePosition` to use the same `native` check as core.interaction.js's version. As best as I can tell, the ChartEvent's x and y are populated from `getRelativePosition`, so the previous `getCanvasPosition` was effectively just duplicating `getRelativePosition'`s work. I added a test to verify this; it depends on a local, not-yet-submitted change in chartjs-test-utils' `triggerMouseEvent` to return the mouse event that it triggers. * Add an API to refactor duplicate isPointInArea * Rename and update JSDoc to prepare for making this public * Give functions a consistent, generic interface * Export functions for discussion * Code review feedback Add a non-null assertion, as requested in code review. Add JSDoc to clarify that `getCanvasPosition` now expects a native `Event`, not a `ChartEvent`. Add `@ts-ignore`; `getCanvasPosition` relied on some loose conversions between `Event`, `TouchEvent`, and `Touch` that would require several changes to make TypeScript happy. * Code review feedback Return the event directly, to speed up the code a bit. Add JSDoc to help communicate its intent. Update various comments. * Finalize exports; add docs and TypeScript * Update src/helpers/helpers.dom.js * Update src/helpers/helpers.dom.js Only thing needed actually is the update of chartjs-test-utils to 0.4.0 * Bump chartjs-test-utils dependency To get supporting work from https://github.com/chartjs/chartjs-test-utils/pull/19 Co-authored-by: Jukka Kurkela <jukka.kurkela@gmail.com> |
||
|---|---|---|
| .. | ||
| animations.md | ||
| canvas-background.md | ||
| decimation.md | ||
| device-pixel-ratio.md | ||
| elements.md | ||
| index.md | ||
| interactions.md | ||
| layout.md | ||
| legend.md | ||
| locale.md | ||
| responsive.md | ||
| subtitle.md | ||
| title.md | ||
| tooltip.md | ||